fix(client): enable to render previous element in slot (experimental) #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Open
dai-shi
pushed a commit
that referenced
this pull request
Jul 10, 2024
It covers #696 and #741. The test aims at how to implement auth features on the app side. Considerations: 1. Our client router has to handle 4xx errors that the server responds 2. Middleware can be a validator to respond to 200 or 4xx status on requests I'm so glad to send my first PR to Waku, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have
main.tsx, we can place an error boundary there.However with managed mode or nested routes, we may want to place an error boundary in RSC.
This enables to use previous elements on client with some condition. It only works with "static" layout.
This is experimental. We should add tests for this to keep the capability, if possible.