Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support js/jsx extensions (minimal api only) #633

Merged
merged 10 commits into from
Mar 30, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 30, 2024

See: 21_minimal_js example

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Mar 30, 2024 9:19am

Copy link

codesandbox-ci bot commented Mar 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Comment on lines +305 to +307
esbuild: {
jsx: 'automatic',
},
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why it worked without this before.

@dai-shi dai-shi marked this pull request as ready for review March 30, 2024 06:38
@dai-shi dai-shi merged commit 71e2749 into main Mar 30, 2024
28 checks passed
@dai-shi dai-shi deleted the js-for-minimal-api branch March 30, 2024 11:02
This was referenced Mar 30, 2024
dai-shi added a commit that referenced this pull request Mar 30, 2024
following #633
see 02_template_js example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant