Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: React.cache to work correctly if AsyncLocalStorage is available #590

Merged
merged 5 commits into from
Mar 10, 2024

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Mar 10, 2024

Related with #587, cache hasn't been working as expected. This is to fix it.

Copy link

vercel bot commented Mar 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Mar 10, 2024 7:00am

Copy link

codesandbox-ci bot commented Mar 10, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@@ -119,6 +119,7 @@ const analyzeEntries = async (
build: {
write: false,
ssr: true,
target: 'node18',
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix #585 too. cc @Aslemammad

@dai-shi dai-shi linked an issue Mar 10, 2024 that may be closed by this pull request
@dai-shi dai-shi marked this pull request as ready for review March 10, 2024 08:58
@dai-shi dai-shi merged commit 8ff7829 into main Mar 10, 2024
28 checks passed
@dai-shi dai-shi deleted the fix/cache branch March 10, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top-level await is not available
1 participant