Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(path-types): allow # and ? links for to prop #1137

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

tylersayshi
Copy link
Contributor

@tylersayshi tylersayshi commented Jan 8, 2025

fixes #1134

I'd like to have more robust testing for these path types but that seems lower priority to setup for now. Maybe a v1 alpha task?

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Jan 8, 2025 6:29am

Copy link

codesandbox-ci bot commented Jan 8, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dai-shi dai-shi mentioned this pull request Jan 8, 2025
@dai-shi dai-shi merged commit b08682b into dai-shi:main Jan 8, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

types for routing are too strict
2 participants