Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking(minimal): handleBuild API for build #1093

Merged
merged 20 commits into from
Dec 28, 2024
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Dec 26, 2024

also changes define-router

Copy link

vercel bot commented Dec 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Dec 27, 2024 11:37pm

Copy link

codesandbox-ci bot commented Dec 26, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@dai-shi dai-shi mentioned this pull request Dec 27, 2024
@dai-shi dai-shi changed the title refactor(minimal): handleBuild breaking(minimal): handleBuild API for build Dec 27, 2024
@dai-shi dai-shi marked this pull request as ready for review December 27, 2024 06:40
@tylersayshi
Copy link
Contributor

this change is significant. I'm curious, what was the motivation for this refactor?

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 27, 2024

It's to support api routes. Long journey.

@tylersayshi
Copy link
Contributor

It's to support api routes. Long journey.

wow! I did not expect this to be so disruptive to the current code 😲

@dai-shi
Copy link
Owner Author

dai-shi commented Dec 27, 2024

API routes are technically already possible with 39_api example.
But, I would like to build static files like RSS. It's completely a new capability.

@dai-shi dai-shi merged commit ba89aa2 into main Dec 28, 2024
26 checks passed
@dai-shi dai-shi deleted the refactor/build-config branch December 28, 2024 00:10
Comment on lines +65 to +70
htemlHead: generateHtmlHead(),
}),
async () => ({
type: 'defaultHtml' as const,
pathname: '/no-ssr',
htemlHead: generateHtmlHead(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dai-shi I think htemlHead might be a typo?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, no. Yeah, thanks for pointing it out.

@dai-shi dai-shi mentioned this pull request Dec 31, 2024
dai-shi added a commit that referenced this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants