-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(minimal): handleBuild API for build #1093
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
this change is significant. I'm curious, what was the motivation for this refactor? |
It's to support api routes. Long journey. |
wow! I did not expect this to be so disruptive to the current code 😲 |
API routes are technically already possible with 39_api example. |
htemlHead: generateHtmlHead(), | ||
}), | ||
async () => ({ | ||
type: 'defaultHtml' as const, | ||
pathname: '/no-ssr', | ||
htemlHead: generateHtmlHead(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dai-shi I think htemlHead might be a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, no. Yeah, thanks for pointing it out.
also changes define-router