Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: recording video in exported html #46

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Conversation

dai-shi
Copy link
Owner

@dai-shi dai-shi commented Aug 23, 2021

If you export to html and then open the html file in Chrome, you can record video of your slides (with or without animations).

Steps without audio

  1. Click record button
  2. Select Chrome Tab in screen sharing
  3. Deny microphone access
  4. (after finished) Stop screen sharing

Steps with audio

  1. Click record button
  2. Select Chrome Tab in screen sharing
  3. Allow microphone access
  4. (after finished) Stop screen sharing
  5. Click the record button again to save file

Screen.Recording.2021-08-23.at.9.07.05.mov

@vercel
Copy link

vercel bot commented Aug 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/daishi/excalidraw-claymate/DAs4bMvegNCkhY2MBW5xy8fRibcr
✅ Preview: https://excalidraw-claymate-git-feat-record-in-exported-html-daishi.vercel.app

grant-davidson
grant-davidson previously approved these changes Aug 23, 2021
Copy link
Collaborator

@grant-davidson grant-davidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@grant-davidson
Copy link
Collaborator

grant-davidson commented Aug 23, 2021

Are you planning to add the usage instructions to the readme?
It's probably worth prefixing your current instructions with "If you export to html and then open the html file in Chrome...." or similar

@dai-shi
Copy link
Owner Author

dai-shi commented Aug 23, 2021

good point. do you have an idea to improve the description in README?

@grant-davidson
Copy link
Collaborator

At some stage we should probably add some documentation that is accessible from the app itself (similar to or replacing the excalidraw help) but I think the pull request link is ok for now.

@dai-shi
Copy link
Owner Author

dai-shi commented Aug 24, 2021

Thanks!

@dai-shi dai-shi merged commit 95372fa into master Aug 24, 2021
@dai-shi dai-shi deleted the feat/record-in-exported-html branch August 24, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants