Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#799] scheduler: fix: skipIfSuccessful skips too much #811

Merged
merged 7 commits into from
Feb 6, 2025

remove unused test file

6bb4620
Select commit
Loading
Failed to load commit list.
Merged

[#799] scheduler: fix: skipIfSuccessful skips too much #811

remove unused test file
6bb4620
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 6, 2025 in 1s

56.06% (+0.50%) compared to 9344144

View this Pull Request on Codecov

56.06% (+0.50%) compared to 9344144

Details

Codecov Report

Attention: Patch coverage is 64.12556% with 80 lines in your changes missing coverage. Please review.

Project coverage is 56.06%. Comparing base (9344144) to head (6bb4620).

Files with missing lines Patch % Lines
internal/scheduler/manager.go 68.14% 33 Missing and 3 partials ⚠️
internal/scheduler/job.go 48.00% 25 Missing and 1 partial ⚠️
internal/scheduler/scheduler.go 68.96% 15 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #811      +/-   ##
==========================================
+ Coverage   55.55%   56.06%   +0.50%     
==========================================
  Files          73       73              
  Lines        7905     7921      +16     
==========================================
+ Hits         4392     4441      +49     
+ Misses       3134     3102      -32     
+ Partials      379      378       -1     
Files with missing lines Coverage Δ
cmd/setup.go 75.95% <100.00%> (+0.13%) ⬆️
internal/scheduler/scheduler.go 68.50% <68.96%> (+6.19%) ⬆️
internal/scheduler/job.go 44.06% <48.00%> (+44.06%) ⬆️
internal/scheduler/manager.go 68.14% <68.14%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9344144...6bb4620. Read the comment docs.