Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect paths in config docs #713

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

jonnochoo
Copy link
Contributor

@jonnochoo jonnochoo commented Nov 15, 2024

From my experience the default paths for DAGU_LOG_DIR and DAGU_DATA_DIR are incorrect?

Not sure about DAGU_ADMIN_LOG_DIR...

If I'm wrong, feel free to close this PR :)

@yottahmd
Copy link
Collaborator

Great catch! thanks for the fix! :)

@yottahmd yottahmd merged commit 6ce3fdd into dagu-org:main Nov 15, 2024
4 checks passed
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.80%. Comparing base (2e627d8) to head (dee4f97).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #713   +/-   ##
=======================================
  Coverage   61.80%   61.80%           
=======================================
  Files          53       53           
  Lines        5249     5249           
=======================================
  Hits         3244     3244           
  Misses       1751     1751           
  Partials      254      254           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e627d8...dee4f97. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants