Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init dag dir #537

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Init dag dir #537

merged 1 commit into from
Mar 14, 2024

Conversation

HtcOrange
Copy link
Contributor

@HtcOrange HtcOrange commented Mar 13, 2024

As this issue: #530

During the testing process, I found that the scheduler tried to find the directory "$HOME/. dagu/dags" when starting, but it did not create this directory. This can lead to a problem: the scheduler will not be able to start the watcher service when it cannot find this directory, but it will not exit itself. Therefore, when adding a cron task on the page, these cron tasks will not be scheduled. When users perform queries or add tasks on the page, the directory of dags will be automatically created. However, since it is not a hot load, the scheduler will not re read this directory, and subsequent watcher services will never start unless the scheduler is manually killed and restarted.
In summary, I believe that adding an initialization process can effectively solve this problem.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.83%. Comparing base (cc1b134) to head (0fd6976).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
+ Coverage   72.75%   72.83%   +0.08%     
==========================================
  Files          43       43              
  Lines        3736     3736              
==========================================
+ Hits         2718     2721       +3     
+ Misses        878      876       -2     
+ Partials      140      139       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yohamta
Copy link
Collaborator

yohamta commented Mar 14, 2024

@HtcOrange Amazing. Thank you so much for fixing the problem 👍

@yohamta yohamta merged commit 4cb2e42 into dagu-org:main Mar 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants