Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement start and stop schedule #306

Merged
merged 6 commits into from
Aug 31, 2022
Merged

Implement start and stop schedule #306

merged 6 commits into from
Aug 31, 2022

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 31, 2022

Closes #303

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Base: 86.00% // Head: 85.93% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (2f0fc2e) compared to base (524bac8).
Patch coverage: 80.64% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   86.00%   85.93%   -0.08%     
==========================================
  Files          46       46              
  Lines        3451     3476      +25     
==========================================
+ Hits         2968     2987      +19     
- Misses        352      356       +4     
- Partials      131      133       +2     
Impacted Files Coverage Δ
internal/dag/dag.go 90.35% <80.64%> (-0.90%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yohamta yohamta marked this pull request as ready for review August 31, 2022 14:48
@yohamta yohamta merged commit dc1cf21 into main Aug 31, 2022
@yohamta yohamta deleted the feat/schedule-process branch August 31, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow start and stop time definition for schedule field
2 participants