Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce admin-web bundle.js size #273

Merged
merged 13 commits into from
Aug 18, 2022
Merged

Reduce admin-web bundle.js size #273

merged 13 commits into from
Aug 18, 2022

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 16, 2022

Related to #272

@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2022

Codecov Report

Merging #273 (31ceacd) into main (36e464c) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
- Coverage   85.94%   85.92%   -0.02%     
==========================================
  Files          46       46              
  Lines        3386     3383       -3     
==========================================
- Hits         2910     2907       -3     
  Misses        347      347              
  Partials      129      129              
Impacted Files Coverage Δ
internal/admin/routes.go 100.00% <ø> (ø)
internal/dag/dag.go 91.04% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yohamta yohamta changed the title Fix admin-web bundle.js issue Reduce admin-web bundle.js size Aug 16, 2022
@yohamta yohamta force-pushed the main branch 2 times, most recently from 05735aa to 719b6cb Compare August 17, 2022 00:59
@Arvintian
Copy link
Contributor

About react lazy load?

@yohamta
Copy link
Collaborator Author

yohamta commented Aug 17, 2022

Thanks for the suggestion! Sounds like a good option.

I took a profile and it seems like monaco-editor, mermaid and fontawesome are also taking a lot of space as well as react. I will try to separate these from the bundle.js.
image

@yohamta yohamta force-pushed the fix-web-build-issue branch from 449a4ce to a83428d Compare August 17, 2022 07:17
@yohamta yohamta force-pushed the fix-web-build-issue branch from 3eaf2a9 to 31ceacd Compare August 18, 2022 11:05
@yohamta yohamta marked this pull request as ready for review August 18, 2022 11:10
@yohamta yohamta merged commit 8103f4f into main Aug 18, 2022
@yohamta yohamta deleted the fix-web-build-issue branch August 18, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants