Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter parsing issue #240

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Fix parameter parsing issue #240

merged 1 commit into from
Aug 5, 2022

Conversation

yohamta
Copy link
Collaborator

@yohamta yohamta commented Aug 5, 2022

Fixes #239

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022

Codecov Report

Merging #240 (f5df35d) into main (073b1d3) will decrease coverage by 0.19%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##             main     #240      +/-   ##
==========================================
- Coverage   86.35%   86.15%   -0.20%     
==========================================
  Files          46       46              
  Lines        3275     3286      +11     
==========================================
+ Hits         2828     2831       +3     
- Misses        320      326       +6     
- Partials      127      129       +2     
Impacted Files Coverage Δ
internal/utils/utils.go 83.73% <52.94%> (-5.45%) ⬇️
internal/config/config.go 91.09% <100.00%> (ø)
internal/scheduler/node.go 89.25% <100.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@yohamta yohamta merged commit 5f5ad54 into main Aug 5, 2022
@yohamta yohamta deleted the develop branch August 5, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When a quoted argument contains spaces the parameters are not passed to the command correctly
2 participants