Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] set dagsDir in config not applied #840

Closed
triole opened this issue Feb 15, 2025 · 3 comments
Closed

[bug] set dagsDir in config not applied #840

triole opened this issue Feb 15, 2025 · 3 comments
Assignees
Milestone

Comments

@triole
Copy link
Contributor

triole commented Feb 15, 2025

Thanks for the --config fix. I really enjoy using dagu and appreciate your great work.

Playing with the configuration I just discovered one tiny thing. If you set the dagsDir inside a config file the setting does not seem to be applied. It is not a critical problem because I decided to use the command line arg --dags, which works fine. Nonetheless the documentation states, that also the config file could be used to set the dagsDir.

I think there are two possibilities to go on from here and I am happy to leave you the choice...

  1. Fix the config setting dagsDir, which probably would be a little cleaner because the other dir settings in the config file seem to work.
  2. update the documentation, remove the part about the dagsDir and write that the cli arg --dags is the way to go

As I said thank you for you quick reactions to the issues and the marvellous tool you have given us. Please let me know in case I got something wrong. Have a nice day.

@triole
Copy link
Contributor Author

triole commented Feb 15, 2025

I was playing around a little bit and stumbled across the fact that one directories can only be configured through env variables. Wouldn't it be nice if all the settings that could be applied by env vars would also be available inside the config. I tried the following inside my config and it did not work because the log dir for example was not set.

adminlogDir: /home/usr/data/adminlog
dagsDir: /home/usr/conf/dags
dataDir: /home/usr/data/data
logDir: /home/usr/data/log
suspendflagsDir: /home/usr/data/suspend
workDir: /home/usr/data/work

Just as a suggestion. I would appreciate a config working like that. Thanks.

@yottahmd
Copy link
Collaborator

@triole, thanks for catching that! I really appreciate the detailed suggestions. The actual config key was dags, but the document was incorrect. I’ll fix that by adding a dagsDir config field instead of dags to match the other config keys.

@yottahmd
Copy link
Collaborator

It's fixed in v1.16.3. Thanks again for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants