skipIfSuccessful skips too much

[fbartels]

Reading the documentation at https://dagu.readthedocs.io/en/latest/yaml_format.html#skip-redundant-runs the option should "check[s] if there’s already been a successful run since the last scheduled time. If yes, it skips the execution", but this does not seem to be the case.

I have a dag that has these attributes:

schedule: "0 * * * *"
skipIfSuccessful: true

So from the description it should run every hour and if it has been manually executed in between, would skip the next hourly run. But looking at the logs this rather seems to cause the dag to only every run every second hour.

I have not inspected the code, but could it be that skipIfSuccessful matches on the completion time of a dag and not its starting time?

Using v1.16.0, but I also made the observation with v1.15.0.

[yottahmd]

Thank you so much for reporting the issue. This issue should be fixed in the next release.