[ui] Fix launchpad warning about missing partition for hidden asset job #27340
+305
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
js_modules/dagster-ui/packages/ui-core/src/launchpad/LaunchpadSession.tsx
Outdated
Show resolved
Hide resolved
bengotow
force-pushed
the
bengotow-2025-01/FE-765
branch
from
647ab00 to
4566af2
Compare
bengotow
commented
Jan 24, 2025
| @@ -573,7 +584,10 @@ const LaunchpadSession = (props: LaunchpadSessionProps) => { | |||
| } | |||
|
|
|||
| let launchButtonWarning: string | undefined; | |||
| if (partitionSets.results.length && isMissingPartition(currentSession.base)) { | |||
| if ( | |||
| (partitionSets.results.length || partitionSetDetails.doesAnyAssetHavePartitions) && | |||
There was a problem hiding this comment.
This is the fix! Lifting the data fetching up out of ConfigEditorConfigPicker into a hook is just so that we can reference doesAnyAssetHavePartitions here.
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit d93f959. |
bengotow
force-pushed
the
bengotow-2025-01/FE-765
branch
from
4566af2 to
5cf1d66
Compare
This is a follow-up to https://github.com/dagster-io/dagster/pull/25971/files Resolves https://linear.app/dagster-labs/issue/FE-765/non-partitioned-run-of-partitioned-job In a release this fall, we combined all the hidden asset jobs into a single `__ASSET_JOB` that spans all assets. The objective of this was to enable partition-mapping and allow users to materialize any arbitrary subset of assets. To do this, the partition sets were removed from the hidden job and the appropriate partition set is determined on the fly based on the assets within the job you’re interested in. This broke the warning in this modal, since the job has partitioned assets but does not have `partitionSets`. This looks like a big code change but I just took all the existing loader logic out of ConfigEditorConfigPicker’s partition set + partition picker, and moved it up one layer so that it could be referenced in the warning as well.
bengotow
force-pushed
the
bengotow-2025-01/FE-765
branch
from
5cf1d66 to
d93f959
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to https://github.com/dagster-io/dagster/pull/25971/files
Resolves https://linear.app/dagster-labs/issue/FE-765/non-partitioned-run-of-partitioned-job
Summary & Motivation
In a release this fall, we combined all the hidden asset jobs into a single
__ASSET_JOBthat spans all assets. The objective of this was to enable automatic-partition-mapping and allow users to materialize any arbitrary subset of assets. To do this, the partition sets were removed from the hidden job and the appropriate partition set is determined on the fly based on the assets within the job you’re interested in.This broke the warning in this modal, since the job has partitioned assets but does not have
partitionSets.This looks like a big code change but I just took all the existing loader logic out of ConfigEditorConfigPicker’s partition set + partition picker, and moved it up one layer so that it could be referenced in the warning as well. The queries / transformations of the data, etc. haven't been changed.
How I Tested These Changes
This was fairly easy to repro once I figured it out - just go to the graph (not an asset job) and choose "Open Launchpad" from the materialize dropdown with a partitioned asset selected.
Changelog
[ui] When launching partitioned assets in the launchpad from the global graph, Dagster will warn if you have not made a partition selection.