Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Add DB2 kind icon #27263

Merged
merged 4 commits into from
Jan 29, 2025
Merged

[ui] Add DB2 kind icon #27263

merged 4 commits into from
Jan 29, 2025

Conversation

tintamarre
Copy link
Contributor

Summary & Motivation

Add a new db2 (IBM DB2 https://www.ibm.com/db2) kind and icon downloaded from IBM website and converted to SVG 24px/24px to fill the issue #27189

We're using DB2 and would like this kind to be displayed with an icon in the UI.

This PR is a fix of the previous #27190 that didn't match new architecture of doc site.

@tintamarre
Copy link
Contributor Author

@neverett do you need something from me or is it okay ?

@tintamarre
Copy link
Contributor Author

@braunjj or @garethbrickman do i need to do something on this PR ? thx

@garethbrickman
Copy link
Contributor

@tintamarre No it's in our team's queue for review 👍

Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add db2 to KnownTagType

@tintamarre
Copy link
Contributor Author

@salazarm Is it okay ?

@tintamarre tintamarre requested a review from salazarm January 29, 2025 11:03
@salazarm salazarm merged commit 1baf36a into dagster-io:master Jan 29, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants