[pythonic config][alternate] properly propagate default values set at the top level for nested config classes #27209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the top level for nested config classes
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 17, 2025
dpeng817
approved these changes
Jan 21, 2025
| @@ -433,7 +433,6 @@ def infer_schema_from_config_class( | |||
| " definition. 'dagster.Field' should only be used in legacy Dagster config" | |||
| " schemas. Did you mean to use 'pydantic.Field' instead?" | |||
| ) | |||
|
|
|||
Comment on lines
+145
to
+148
| inferred_field = _apply_defaults_to_schema_field( | ||
| inferred_field, | ||
| pydantic_field.default._convert_to_config_dictionary(), # noqa: SLF001 | ||
| ) |
Comment on lines
+199
to
+207
| a_job.execute_in_process( | ||
| { | ||
| "ops": { | ||
| "a_struct_config_op": { | ||
| "config": {"a_string": "foo", "a_nested": {"inner_config": {"a_float": 3.0}}} | ||
| } | ||
| } | ||
| } | ||
| ) |
There was a problem hiding this comment.
assert result.success. Also, maybe a test on executing with no config at all (should be possible now right)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Alternate implementation of #27206 which relies on the partial config utilities from #12870
Ensures that default values on Pythonic Config get properly propagated to inner Config classes, e.g.
Test Plan
New unit test; todo add a few more