Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dagster-helm] 3.11 str enum compat #19113

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

alangenfeld
Copy link
Member

in 3.11 these f strings change for the enum
python/cpython#100458

so just do .value

How I Tested These Changes

bk passes

@alangenfeld
Copy link
Member Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@alangenfeld alangenfeld force-pushed the al/01-09-_dagster-helm_3.11_str_enum_compat branch from 8ba4906 to 5289f57 Compare January 9, 2024 20:32
@alangenfeld alangenfeld force-pushed the al/01-09-_dagster-helm_3.11_str_enum_compat branch from 5289f57 to cb3ce94 Compare January 9, 2024 20:34
Copy link
Member

@rexledesma rexledesma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pain

@alangenfeld alangenfeld merged commit c98cae5 into master Jan 9, 2024
1 check was pending
@alangenfeld alangenfeld deleted the al/01-09-_dagster-helm_3.11_str_enum_compat branch January 9, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants