[ui] Fix layout for global banner #18817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit d98603e. |
hellendag
force-pushed
the
dish/banner-layout
branch
2 times, most recently
from
f206452 to
a243d2e
Compare
[INTERNAL_BRANCH=dish/banners]
hellendag
force-pushed
the
dish/banner-layout
branch
from
a243d2e to
d98603e
Compare
jmsanders
approved these changes
Dec 20, 2023
salazarm
approved these changes
Dec 20, 2023
salazarm
reviewed
Dec 20, 2023
Comment on lines
+61
to
+62
| overflow: hidden; | ||
| `; |
There was a problem hiding this comment.
Does this need overflow scroll? or is Main the scroller?
There was a problem hiding this comment.
MainContent is the scrollable child, as defined in ContentRoot. ContentRoot is passed in as children here.
jmsanders
pushed a commit
that referenced
this pull request
Dec 20, 2023
## Summary & Motivation The global banner some users are seeing in Cloud is breaking the layout. This is because the banner pushes the main content down below the edge of the viewport. To resolve this, modify the core layout component to accommodate the banner by passing it as a prop. ## How I Tested These Changes Force a banner to appear on the page. Click around throughout the app, verify that pages render correctly and can be scrolled correctly as well, including pages with virtualized tables and DAG views. (cherry picked from commit c1eafcc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
The global banner some users are seeing in Cloud is breaking the layout. This is because the banner pushes the main content down below the edge of the viewport.
To resolve this, modify the core layout component to accommodate the banner by passing it as a prop.
How I Tested These Changes
Force a banner to appear on the page. Click around throughout the app, verify that pages render correctly and can be scrolled correctly as well, including pages with virtualized tables and DAG views.