Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solid hooks strip description from pipeline definition #4355

Closed
dagsterbot bot opened this issue Jul 13, 2021 · 0 comments
Closed

Solid hooks strip description from pipeline definition #4355

dagsterbot bot opened this issue Jul 13, 2021 · 0 comments
Assignees

Comments

@dagsterbot
Copy link

dagsterbot bot commented Jul 13, 2021

Issue from the Dagster Slack

Solid hooks strip description from pipeline definition

This issue was generated from the slack conversation at: https://dagster.slack.com/archives/C01U954MEER/p1626178763107100?thread_ts=1626178763.107100&cid=C01U954MEER

Conversation excerpt:

U01FWJDG396: Hi all! I think I might have found a small bug - or I need some help - when applying a success hook to a pipeline I lose my pipeline's description! :scream:  I think this is new/different behaviour with 0.12.1. Code to reproduce in thread.
U01FWJDG396: ```from dagster import pipeline, success_hook
@success_hook
def much_success(context):
    print("hello")

@pipeline(name="test", description="foo")
def my_pipeline():
   print("bonjour")

my_pipeline.description

@much_success
@pipeline(name="test", description="foo")
def my_pipeline():
    print("bonjour")

my_pipeline.description```

UM49TQ8EB: Thanks for the report!  Looks like this has been broken in this way for a while…
UM49TQ8EB: <@U018K0G2Y85> issue Solid hooks strip description from pipeline definition

Message from the maintainers:

Are you looking for the same documentation content? Give it a 👍. We factor engagement into prioritization.

prha added a commit that referenced this issue Jul 13, 2021
Summary: For #4355

Test Plan: bk

Reviewers: yuhan, alangenfeld, cdecarolis

Reviewed By: alangenfeld

Differential Revision: https://dagster.phacility.com/D8853
@prha prha self-assigned this Jul 13, 2021
@yuhan yuhan closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants