Skip to content

Commit

Permalink
fix: Module.serve should not modify the caller's core module (#7924)
Browse files Browse the repository at this point in the history
* chore: ensure modules are always served semver engine versions

Signed-off-by: Justin Chadwell <me@jedevc.com>

* fix: Module.serve should not modify the caller's core module

The client is expecting a given API - loading a module *shouldn't*
update the version of the API that it's served. This was a minor design
mistake, and just doesn't make sense as is.

Signed-off-by: Justin Chadwell <me@jedevc.com>

* fix: add Terminal.sync for legacy terminal

With the last patch, there are now *no* fields on the `Terminal` type
that are served to a v0.12 CLI. This is an issue, because now, nothing
forces the evaluation of the type!

To avoid this, we add Terminal.sync, which allows the CLI to force
execution of a Terminal type, with a special field just for this. The
fact that this seemed to work before at all is pretty much coincidence.

Signed-off-by: Justin Chadwell <me@jedevc.com>

---------

Signed-off-by: Justin Chadwell <me@jedevc.com>
  • Loading branch information
jedevc authored Jul 18, 2024
1 parent 3a890e9 commit e428709
Showing 1 changed file with 17 additions and 1 deletion.
18 changes: 17 additions & 1 deletion dagger.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit e428709

Please sign in to comment.