Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename repo to dagger-for-github #22

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Conversation

crazy-max
Copy link
Contributor

fixes #21

@shykes @aluzzardi would temporary need admin rights to the repo to rename it when merged and also check everything is ok in the actions marketplace.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@aluzzardi
Copy link
Member

@shykes @aluzzardi would temporary need admin rights to the repo to rename it when merged and also check everything is ok in the actions marketplace.

Done!

Thank you!

@crazy-max
Copy link
Contributor Author

@aluzzardi I merge this one and will debrief with @grouville about the process.

@crazy-max crazy-max merged commit 2e5f57a into dagger:main Feb 25, 2022
@crazy-max crazy-max deleted the renaming branch February 25, 2022 20:25
@crazy-max
Copy link
Contributor Author

crazy-max commented Feb 25, 2022

@grouville We might also change the action name:

name: 'Dagger Action'

to Dagger for GitHub so link in the marketplace would be https://github.com/marketplace/actions/dagger-for-github which would be more aligned with repo name.

Atm still https://github.com/marketplace/actions/dagger-action

@shykes
Copy link

shykes commented Feb 25, 2022 via email

@crazy-max
Copy link
Contributor Author

In the context of Github marketplace, it kind of makes sense that it would be https://github.com/marketplace/actions/dagger seems more natural

We can't unfortunately. Name in marketplace is tied to username/orgname on GitHub so we can't pick /dagger as it's already used by dagger itself 😅.

@shykes
Copy link

shykes commented Mar 8, 2022

Makes sense. I think most people (me included) will copy-paste the workflow yaml anyway. Thanks!

@grouville
Copy link
Member

le (me included) will copy-paste the workflow yaml anyway. Thanks!

do you prefer appearing as dagger-action in the marketplace (as it is now) ? or dagger-for-github ?

@shykes
Copy link

shykes commented Mar 8, 2022

For consistency, I would prefer dagger-for-github. Less different words to remember :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename dagger-action to something less confusing
4 participants