-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align versioning of dagger-for-github with dagger engine? #24
Comments
Copying @gerhard so he can track which tag to use in getting started. |
The todoapp example contains a Netlify plan which uses the latest dagger additions: do & Client API. We are thinking of merging the examples repository into this one to make working with this easier. This is a step in that direction. We are not using the yarn package so that we can revert #1673 without breaking this implementation. The GitHub Action is WIP, we will continue with that tomorrow: dagger/dagger-for-github#24 Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
We (+ @crazy-max @aluzzardi) have decided to keep versioning as is because there will be changes that we will need to make in the action that are unrelated to Dagger (e.g. upgrade node version, add new config parameters, etc.). The simplest thing was to link This can be closed for now, but we should re-open if we think this is still relevant. |
I agree, this makes sense, especially since you can configure the version of |
It seems that dagger-for-github has its own versioning:
v1
,v2
, etc. I understand how this makes sense (it is its own software, makes sense to have its own versioning schema). But from the point of view of a Dagger user, I find it confusing because I only care about version of Dagger. How do I choose the right version of dagger-for-github? I might have to look up a version mapping...it would be great if we could change the versioning of dagger-for-github so that it aligns with the versioning of dagger (ie. version 0.2 -> 0.2). Thoughts?
The text was updated successfully, but these errors were encountered: