Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align versioning of dagger-for-github with dagger engine? #24

Closed
shykes opened this issue Mar 8, 2022 · 3 comments
Closed

Align versioning of dagger-for-github with dagger engine? #24

shykes opened this issue Mar 8, 2022 · 3 comments
Assignees

Comments

@shykes
Copy link

shykes commented Mar 8, 2022

It seems that dagger-for-github has its own versioning: v1, v2, etc. I understand how this makes sense (it is its own software, makes sense to have its own versioning schema). But from the point of view of a Dagger user, I find it confusing because I only care about version of Dagger. How do I choose the right version of dagger-for-github? I might have to look up a version mapping...

it would be great if we could change the versioning of dagger-for-github so that it aligns with the versioning of dagger (ie. version 0.2 -> 0.2). Thoughts?

@shykes
Copy link
Author

shykes commented Mar 8, 2022

Copying @gerhard so he can track which tag to use in getting started.

gerhard added a commit to dagger/dagger that referenced this issue Mar 8, 2022
The todoapp example contains a Netlify plan which uses the latest dagger
additions: do & Client API. We are thinking of merging the examples
repository into this one to make working with this easier. This is a
step in that direction.

We are not using the yarn package so that we can revert
#1673 without breaking this
implementation.

The GitHub Action is WIP, we will continue with that tomorrow:
dagger/dagger-for-github#24

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
@gerhard
Copy link
Member

gerhard commented Mar 10, 2022

We (+ @crazy-max @aluzzardi) have decided to keep versioning as is because there will be changes that we will need to make in the action that are unrelated to Dagger (e.g. upgrade node version, add new config parameters, etc.).

The simplest thing was to link v1 in the action to Dagger 0.1 (pre-Europa) #28 and create v2 which defaults to Dagger 0.2 (Europa) #30

This can be closed for now, but we should re-open if we think this is still relevant.

@gerhard gerhard closed this as completed Mar 10, 2022
@shykes
Copy link
Author

shykes commented Mar 10, 2022

I agree, this makes sense, especially since you can configure the version of dagger to use in the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants