fix: Omit type antecedents for unassigned variables #5877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
approved these changes
Nov 5, 2024
| function Search4<T(==)>(s: seq<T>, x: T): (o: Option<int>) | ||
| ensures | ||
| o.Some? && o.value < |s| ==> | ||
| s[o.value] == x // error: ".value" may be negative |
There was a problem hiding this comment.
How does this function relates to the soundness issue being solved? Is that the baseline without subset types?
There was a problem hiding this comment.
Yes, that's the baseline -- just to make sure there's nothing else that causes the other tests to pass.
| git-issue-1958.dfy(18,16): Error: value does not satisfy the subset constraints of 'R' | ||
| git-issue-1958.dfy(32,4): Error: value does not satisfy the subset constraints of 'R' | ||
| git-issue-1958.dfy(36,4): Error: value does not satisfy the subset constraints of 'R' | ||
| git-issue-1958.dfy(56,16): Error: function precondition could not be proved |
There was a problem hiding this comment.
That one, along with the one line 104, is not triggered on my machine and that's a soundness issue. So you fixed it !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In let expressions and named function results, the bound variable was previously introduced with an assumption that the variable satisfied its type. That is not sound, since the type may be empty. This PR removes those premature type assumptions.
Fixes #1958
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.