Isolate paths #5832
Merged
Isolate paths #5832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ens passed to Boogie
keyboardDrummer
force-pushed
the
isolatePaths
branch
from
e55e0ea to
2a9e9e1
Compare
robin-aws
requested changes
Oct 23, 2024
Source/Dafny.sln
Outdated
.gitmodules
Outdated
| CHECK: Verified part #7, 8/10 of f, on line 5, verified successfully \(time: .*, resource count: .*\) | ||
| CHECK: Verified part #8, 9/10 of f, on line 5, verified successfully \(time: .*, resource count: .*\) | ||
| CHECK: Verified part #9, 10/10 of f, on line 5, verified successfully \(time: .*, resource count: .*\) | ||
| CHECK: Verified 1/10 of f: assertion at line 5, verified successfully \(time: .*, resource count: .*\) |
There was a problem hiding this comment.
This reformatting is definitely an improvement. In the future it would be nice to be more specific about what part of the assertion is verified in this batch though.
| @@ -0,0 +1,70 @@ | |||
| // RUN: ! %verify --progress VerificationJobs --cores=1 %s &> %t | |||
| // RUN: %OutputCheck --file-to-check "%t" "%s" | |||
| // CHECK:Verified 1/2 of Assertion: assertion at line 19, could not prove all assertions | |||
There was a problem hiding this comment.
Suggested change
| // CHECK:Verified 1/2 of Assertion: assertion at line 19, could not prove all assertions | |
| // CHECK:Verified 1/2 of Assertion: assertion at line 19 - could not prove all assertions |
Or something like that. The comma feels like too weak a separator.
| @@ -0,0 +1,49 @@ | |||
| // RUN: ! %verify --progress VerificationJobs --cores=1 %s &> %t | |||
| // RUN: %OutputCheck --file-to-check "%t" "%s" | |||
| // CHECK:Verified 1/4 of Assertion: assertion at line 28, through \[15,23\], could not prove all assertions | |||
There was a problem hiding this comment.
See boogie-org/boogie#970 (comment), I think we should label the numbers as line numbers in a path more clearly somehow.
Co-authored-by: Robin Salkeld <salkeldr@amazon.com>
Co-authored-by: Robin Salkeld <salkeldr@amazon.com>
Co-authored-by: Robin Salkeld <salkeldr@amazon.com>
robin-aws
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
{:isolate "paths"}onassert,returnandcontinuestatements.Out of scope
{:isolate "paths"}for implicit assertionsTesting
isolatePaths.dfyBy submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.