Fix: Format for comprehension expressions #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
reviewed
May 4, 2023
| PartC, | ||
| j | ||
| <- PartD + | ||
| PartE |
There was a problem hiding this comment.
Is this PartE intended to be aligned with PartD, or is it supposed to be one 2-space indent past the corresponding <-?
There was a problem hiding this comment.
It is intended to be aligned with PartD. Specifically, the "<-" is treated like an "in" binary operator, and I put the rule that if the "in" operator is not followed by a newline, then it starts a new aligning indentation. If it is followed by a newline, then it's indented by two spaces as usual. This matches usages of newlines I've seen for the second argument of "in" and "<-"
alex-chew
previously approved these changes
May 4, 2023
alex-chew
previously approved these changes
May 5, 2023
alex-chew
previously approved these changes
May 8, 2023
alex-chew
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3912
Specifically, I ensured that "in" and "<-" operator indent their second operator compared to the first, but if "<-" starts the line, then it indents its second argument only relative to itself.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.