Allocated 4 default #3637
Merged
Allocated 4 default #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyboardDrummer
previously approved these changes
Feb 27, 2023
robin-aws
approved these changes
Feb 27, 2023
|
Note that two jobs were hung for over an hour - I cancelled them in order to attempt a re-run, but then the PR was auto-merged anyway for some reason. I suspect an internal GitHub error of some kind. We can rely on the deep tests on this branch to catch things if there was actually a failure lurking there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
/allocated:4the default, which addresses soundness issues with/allocated:3.The PR also deprecates the
/allocatedoption. Going forward, Dafny will support only one encoding of the allocation state (namely, the one that's/allocated:4). As far as I know, the previous users of/allocated:1or/allocated:2are no longer using an/allocatedsetting.By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.