Fix: Proper warning that 'new' cannot be used in expressions, instead of a parse error #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelMayer
commented
Jan 18, 2023
| @@ -14,7 +14,7 @@ public class ExitCommand : ILitCommand { | |||
|
|
|||
| public (int, string, string) Execute(ITestOutputHelper? outputHelper, TextReader? inputReader, TextWriter? outputWriter, TextWriter? errorWriter) { | |||
| var (exitCode, output, error) = operand.Execute(outputHelper, inputReader, outputWriter, errorWriter); | |||
| return (exitCode != expectedExitCode ? 1 : 0, output, error); | |||
| return (exitCode != expectedExitCode ? 1 : 0, output, error + $"\nMoreover the expected exit code was {expectedExitCode} but got {exitCode}"); | |||
There was a problem hiding this comment.
This is manually tested and was useful to understand why my original tests with %exits-with 1 was failing without indication about what was wrong.
alex-chew
reviewed
Jan 18, 2023
Co-authored-by: Alex Chew <alex-chew@users.noreply.github.com>
davidcok
pushed a commit
to davidcok/dafny
that referenced
this pull request
Jan 20, 2023
… of a parse error (dafny-lang#3374) Co-authored-by: Alex Chew <alex-chew@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #3366
It does not remove the parse error as it was expected, but it does add an explanation of it.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.