-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: More hovering information on the LSP #3282
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found bugs if hovering over the "return" in this program: module ProblemModule {
datatype X =
| Cons(head: int, tail: X)
| Nil
{
predicate method Valid() {
this.Cons? && tail.Valid()
}
}
}
method Test() returns (j: int)
ensures j == 1
{
return 2;
} |
keyboardDrummer
previously approved these changes
Dec 28, 2022
Fixed the reported error
One more failing test case datatype ValidTester = Tester(next: ValidTester2) | Tester2(next: ValidTester2) | Test3(next: ValidTester2)
{
predicate Valid() {
((this.Tester? || this.Tester2?) && this.next.Valid()) || (this.Test3? && !this.next.Valid())
}
function method apply(): int requires Valid() {
2
}
static method Test(c: ValidTester) {
var x := c.apply();
}
}
datatype ValidTester2 = MoreTest(i: int, next: ValidTester2) | End {
predicate Valid(defaultValue: int := 0) {
0 <= defaultValue &&
(this.End? || (this.MoreTest? && this.next.Valid() && i > 0))
}
} If you hover over the failing c.apply(), it will quote random things. I guess it's because there is a defaultValue whose token is outside of the regular range. |
keyboardDrummer
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3281
Fixes dafny-lang/ide-vscode#335
Fixes dafny-lang/ide-vscode#317
Fixes dafny-lang/ide-vscode#210
Example code:
I added language server tests and tested it in VSCode, and it works as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.