Fix: Function by method with the same name as a method won't crash resolver #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-chew
previously approved these changes
Nov 8, 2022
Source/DafnyCore/Resolver.cs
Outdated
| // method should have been filled in by now, | ||
| // unless there was a function by method and a method of the same name | ||
| // but then this error must have been reported. | ||
| Contract.Assert(reporter.ErrorCount >= 1); |
There was a problem hiding this comment.
nit: Why >= 1 here but > 0 in the other case?
There was a problem hiding this comment.
nit: Why >= 1 here but > 0 in the other case?
i did not do them at the same time :-) will fix it for consistency.
MikaelMayer
commented
Nov 8, 2022
alex-chew
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2019
I added the corresponding test.
The story was that, if a function by method and a method had the same name, the function by method's resolved method was null. However, there were two places in the resolver, before it gives up, that were asserting that the function by method's method was not null, so I added a conditional instead and ensured that the number of reported errors was greater than zero.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.