Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build.yml): fix armv7 packages' architecture #145

Merged
merged 17 commits into from
Jul 16, 2023

Conversation

MarksonHon
Copy link
Contributor

Background

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@MarksonHon
Copy link
Contributor Author

DON'T merge this pull request until fpm fix pacman's build bug

@kunish
Copy link
Member

kunish commented Jul 10, 2023

OK, noted, we can mark this PR as DRAFT for now to be extra safe

piyoki
piyoki previously approved these changes Jul 10, 2023
@piyoki
Copy link
Contributor

piyoki commented Jul 10, 2023

I think we also need to update pr-build.yml, release.yml, and prerelease

@kunish kunish marked this pull request as draft July 10, 2023 13:33
@MarksonHon
Copy link
Contributor Author

Finished those jobs:

  1. Fix armv7 packages' architectures, it should be armhf in Debian, arm7hf in Arch Linux ARM and armhfp in RPM.
  2. Arch Linux ARM and RPM use aarch64 for arm64 architecture, while Debian use arm64.
  3. Don't build MIPS family's pacman package for Arch Linux MIPS port has died for 10 years.
    This PR can be merged now

@kunish
Copy link
Member

kunish commented Jul 15, 2023

@yqlbu instantiate-check-runs is causing PR build failure, please help

@piyoki
Copy link
Contributor

piyoki commented Jul 15, 2023

@kunish Sure, let me take a closer look

@piyoki
Copy link
Contributor

piyoki commented Jul 15, 2023

@yqlbu instantiate-check-runs is causing PR build failure, please help

The root cause is that the feature-branch is outside of daeuniverse. For now, it is hard to fix. As a temporary solution, @MarksonHon please push your local branch branch to origin daeuniverse followed by the commands below:

git remote add upstream https://github.com/daeuniverse/daed
git fetch upstream --prune
git push -u upstream <your feature branch name>

@piyoki
Copy link
Contributor

piyoki commented Jul 15, 2023

@yqlbu instantiate-check-runs is causing PR build failure, please help

The root cause is that the feature-branch is outside of daeuniverse. For now, it is hard to fix. As a temporary solution, @MarksonHon please push your local branch branch to origin daeuniverse followed by the commands below:

git remote add upstream https://github.com/daeuniverse/daed
git fetch upstream --prune
git push -u upstream <your feature branch name>

Issue was resolved in #167

@MarksonHon MarksonHon marked this pull request as ready for review July 16, 2023 04:14
.github/workflows/build.yml Show resolved Hide resolved
MarksonHon and others added 2 commits July 16, 2023 12:43
Co-authored-by: kunish <17328586+kunish@users.noreply.github.com>
@MarksonHon
Copy link
Contributor Author

I think we also need to update pr-build.yml, release.yml, and prerelease

pr-build.yml has no package build flow, sync to release.yml and prerelease.yml

Copy link
Member

@kunish kunish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's too complicated for me to really have a good understanding what this PR is doing, can you leave a brief explanation to help people like me?

@MarksonHon
Copy link
Contributor Author

It's too complicated for me to really have a good understanding what this PR is doing, can you leave a brief explanation to help people like me?

#145 (comment)

Some packages built by Action cannot be installed on target operating system, such as Arch Linux ARM64, Debian armv7, this PR is coming for fixing this problem

@piyoki piyoki merged commit eb28321 into daeuniverse:main Jul 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants