Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wildcard origin matching and manual reply function binding #7

Merged
merged 10 commits into from
Nov 30, 2011
Merged

Add wildcard origin matching and manual reply function binding #7

merged 10 commits into from
Nov 30, 2011

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented Sep 26, 2011

Fixes #5, #6, #8 and #9

@daepark
Copy link
Owner

daepark commented Sep 26, 2011

Thanks. I will take a look at your patches and merge them in

On Sep 26, 2011, at 12:25 AM, Jon Gjengsetreply@reply.github.com wrote:

You can merge this Pull Request by running:

git pull https://github.com/Jonhoo/postmessage master

Or you can view, comment on it, or merge it online at:

#7

-- Commit Summary --

-- File Changes --

M postmessage.js (55)

-- Patch Links --

https://github.com/daepark/postmessage/pull/7.patch
https://github.com/daepark/postmessage/pull/7.diff

Reply to this email directly or view it on GitHub:
#7

@jonhoo
Copy link
Contributor Author

jonhoo commented Nov 8, 2011

Any progress on merging these commits?

@daepark
Copy link
Owner

daepark commented Nov 8, 2011

Hi Jon,

Sorry, I was away for vacation for the past month.

  1. Regarding "*" origin, I've submitted your change and also it also
    works when using hash (#) messages.
  2. The async responses is a great idea, but I would like to NOT use a
    different bind method (bind_c) but rather use the same bind with
    different options?? If you can do this it would be great!
  3. My try/catch thing /is a little overkill, but I wanted a way to
    call the requester's error handler for ANY errors. Maybe I can just
    re-throw the exception if an errback is not defined?

Anyhow, I've now also added qunit tests for same origin
(test/test.html) and cross origin (test/test-x.html).
If you can add tests along with your fixes/features, that would be great!

-dae

On Tue, Nov 8, 2011 at 12:27 AM, Jon Gjengset
reply@reply.github.com
wrote:

Any progress on merging these commits?


Reply to this email directly or view it on GitHub:
#7 (comment)

@jonhoo
Copy link
Contributor Author

jonhoo commented Nov 10, 2011

Those commits fix your second and third point from above.
I'm a bit short on time right now, so I don't have the time to implement testing code.
Might do it later if I get the time and don't forget.

@jonhoo
Copy link
Contributor Author

jonhoo commented Nov 30, 2011

Any ETA on the merging of this pull request?

@daepark daepark merged commit 881a6cd into daepark:master Nov 30, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No option for manually calling reply function in pm.bind
2 participants