Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: URL encoding fixed while forwarding the request to the upstream in proxy mode #716

Merged
merged 6 commits into from
Jun 24, 2023

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jun 24, 2023

Related issue(s)

closes #715

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.

Description

Fixes the duplicate url encoding

@dadrus dadrus changed the title fix: URL encoding while forwarding the request to the upstream in proxy mode fix: URL encoding fixed while forwarding the request to the upstream in proxy mode Jun 24, 2023
@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Merging #716 (6b8eddc) into main (353453f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #716   +/-   ##
=======================================
  Coverage   89.49%   89.49%           
=======================================
  Files         213      213           
  Lines        9107     9107           
=======================================
  Hits         8150     8150           
  Misses        765      765           
  Partials      192      192           
Impacted Files Coverage Δ
internal/fiber/middleware/xfmphu/request_url.go 100.00% <100.00%> (ø)
internal/handler/requestcontext/request_context.go 76.05% <100.00%> (-0.98%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit 9234ea1 into main Jun 24, 2023
@dadrus dadrus deleted the fix/url_encoding_for_upstream branch June 24, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL path is urlencoded twice when used to forward the request to the upstream in proxy mode
1 participant