Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Header matching case-sensitivity fixed #483

Merged
merged 2 commits into from
Feb 8, 2023

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Feb 8, 2023

Related issue(s)

closes #472

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.

Description

Closes a bug related to header matching during error handler execution

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #483 (4ee703e) into main (ffb3668) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #483      +/-   ##
==========================================
+ Coverage   88.32%   88.37%   +0.05%     
==========================================
  Files         194      194              
  Lines        8002     8003       +1     
==========================================
+ Hits         7068     7073       +5     
+ Misses        764      760       -4     
  Partials      170      170              
Impacted Files Coverage Δ
...mechanisms/errorhandlers/matcher/header_matcher.go 100.00% <100.00%> (ø)
internal/rules/repository.go 97.29% <0.00%> (+3.60%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit 6d31d01 into main Feb 8, 2023
@dadrus dadrus deleted the fix/header_matching_case_sensitivity branch February 8, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header matching is not case-insenitive as defined by RFC 2616
1 participant