Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Memory leak introduced by correlation between metrics & traces fixed #449

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Jan 18, 2023

Related issue(s)

closes #448 and reverts tracing and metrics correlation introduced in #359

Checklist

  • I agree to follow this project's Code of Conduct.
  • I have read, and I am following this repository's Contributing Guidelines.
  • I have read the Security Policy.
  • I have referenced an issue describing the bug/feature request.
  • I have added tests that prove the correctness of my implementation.
  • I have updated the documentation.

Description

Correlating metrics and traces was a very bad idea!

@dadrus dadrus changed the title fix: Memory leak created by correlation between metrics & traces fixed fix: Memory leak introduced by correlation between metrics & traces fixed Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #449 (2dba8bb) into main (4213d27) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #449      +/-   ##
==========================================
- Coverage   88.20%   88.17%   -0.03%     
==========================================
  Files         200      200              
  Lines        8069     8053      -16     
==========================================
- Hits         7117     7101      -16     
  Misses        780      780              
  Partials      172      172              
Impacted Files Coverage Δ
internal/fiber/middleware/prometheus/handler.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit f00e0ec into main Jan 18, 2023
@dadrus dadrus deleted the fix/memory_issue branch January 18, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There seems to be a memory leak with constantly growing memory consumption
1 participant