Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update module github.com/fsnotify/fsnotify to v1.6.0 #271

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 13, 2022

Mend Renovate

This PR contains the following updates:

Package Type Update Change
github.com/fsnotify/fsnotify require minor v1.5.4 -> v1.6.0

Release Notes

fsnotify/fsnotify

v1.6.0

Compare Source

This version of fsnotify needs Go 1.16 (this was already the case since 1.5.1, but not documented). It also increases the minimum Linux version to 2.6.32.

Additions
  • all: add Event.Has() and Op.Has() (#​477)

    This makes checking events a lot easier; for example:

      if event.Op&Write == Write && !(event.Op&Remove == Remove) {
      }
    

    Becomes:

      if event.Has(Write) && !event.Has(Remove) {
      }
    
  • all: add cmd/fsnotify (#​463)

    A command-line utility for testing and some examples.

Changes and fixes
  • inotify: don't ignore events for files that don't exist (#​260, #​470)

    Previously the inotify watcher would call os.Lstat() to check if a file still exists before emitting events.

    This was inconsistent with other platforms and resulted in inconsistent event reporting (e.g. when a file is quickly removed and re-created), and generally a source of confusion. It was added in 2013 to fix a memory leak that no longer exists.

  • all: return ErrNonExistentWatch when Remove() is called on a path that's
    not watched (#​460)

  • inotify: replace epoll() with non-blocking inotify (#​434)

    Non-blocking inotify was not generally available at the time this library was written in 2014, but now it is. As a result, the minimum Linux version is bumped from 2.6.27 to 2.6.32. This hugely simplifies the code and is faster.

  • kqueue: don't check for events every 100ms (#​480)

    The watcher would wake up every 100ms, even when there was nothing to do. Now it waits until there is something to do.

  • macos: retry opening files on EINTR (#​475)

  • kqueue: skip unreadable files (#​479)

    kqueue requires a file descriptor for every file in a directory; this would fail if a file was unreadable by the current user. Now these files are simply skipped.

  • windows: fix renaming a watched directory if the parent is also watched (#​370)

  • windows: increase buffer size from 4K to 64K (#​485)

  • windows: close file handle on Remove() (#​288)

  • kqueue: put pathname in the error if watching a file fails (#​471)

  • inotify, windows: calling Close() more than once could race (#​465)

  • kqueue: improve Close() performance (#​233)

  • all: various documentation additions and clarifications.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependency label Oct 13, 2022
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #271 (ec00d26) into main (c4de55b) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #271      +/-   ##
==========================================
- Coverage   85.98%   85.94%   -0.05%     
==========================================
  Files         156      156              
  Lines        6531     6531              
==========================================
- Hits         5616     5613       -3     
- Misses        783      785       +2     
- Partials      132      133       +1     
Impacted Files Coverage Δ
internal/rules/repository.go 94.40% <0.00%> (-3.20%) ⬇️
internal/rules/provider/filesystem/file_system.go 81.60% <0.00%> (+0.57%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit 465b806 into main Oct 13, 2022
@dadrus dadrus deleted the renovate/github.com-fsnotify-fsnotify-1.x branch October 13, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant