-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Configuration settings for services exposed by heimdall simplified #2089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2089 +/- ##
==========================================
- Coverage 89.45% 89.37% -0.09%
==========================================
Files 271 272 +1
Lines 11487 11474 -13
==========================================
- Hits 10276 10255 -21
- Misses 970 975 +5
- Partials 241 244 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
None
Checklist
Description
This PR refactors heimdall’s
serve
configuration to improve clarity and eliminate redundancy. Currently, the configuration under theserve
property contains separate settings forproxy
anddecision
operation modes, which are mutually exclusive but largely similar. Additionally, settings formanagement
service are included under the sameserve
property, while settings for other services, such as metrics and profiling, are not.The current structure looks like this:
This configuration feels unnecessarily complex, as
proxy
anddecision
modes share many settings but are configured separately. Moreover,management
and other services aren’t grouped logically, making the structure harder to follow.To address these issues, this PR simplifies the configuration by merging the
proxy
anddecision
settings directly under theserve
property and moving themanagement
settings to the top level. The new structure is as follows: