Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accesslog handler does not contain information about authenticated subject if present on errors #162

Merged
merged 1 commit into from
Aug 12, 2022

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Aug 12, 2022

closes #141

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #162 (160f488) into main (5a1125b) will increase coverage by 0.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
+ Coverage   85.82%   85.83%   +0.01%     
==========================================
  Files         147      147              
  Lines        5630     5635       +5     
==========================================
+ Hits         4832     4837       +5     
- Misses        673      674       +1     
+ Partials      125      124       -1     
Impacted Files Coverage Δ
...al/fiber/middleware/accesslog/accesslog_handler.go 75.36% <33.33%> (-1.21%) ⬇️
internal/x/tracing/provider/instana/logger.go 75.00% <0.00%> (-25.00%) ⬇️
internal/rules/repository.go 97.60% <0.00%> (+3.19%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dadrus dadrus merged commit 3e286db into main Aug 12, 2022
@dadrus dadrus deleted the fix/subject_present_in_access_log_on_error branch August 12, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant