Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Configurable fallback of authenticators even if the verification of the credentials fails #134

Merged
merged 13 commits into from
Aug 1, 2022

Conversation

dadrus
Copy link
Owner

@dadrus dadrus commented Aug 1, 2022

closes #92
closes #133

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #134 (0073a05) into main (ed61e18) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   85.79%   85.86%   +0.06%     
==========================================
  Files         147      147              
  Lines        5547     5581      +34     
==========================================
+ Hits         4759     4792      +33     
- Misses        668      669       +1     
  Partials      120      120              
Impacted Files Coverage Δ
...pipeline/authenticators/anonymous_authenticator.go 91.42% <100.00%> (+0.80%) ⬆️
...ipeline/authenticators/basic_auth_authenticator.go 93.38% <100.00%> (+0.34%) ⬆️
...l/pipeline/authenticators/generic_authenticator.go 90.74% <100.00%> (+0.99%) ⬆️
...ernal/pipeline/authenticators/jwt_authenticator.go 89.53% <100.00%> (+0.26%) ⬆️
...rnal/pipeline/authenticators/noop_authenticator.go 100.00% <100.00%> (ø)
...thenticators/oauth2_introspection_authenticator.go 92.07% <100.00%> (+0.25%) ⬆️
...eline/authenticators/unauthorized_authenticator.go 95.00% <100.00%> (+0.88%) ⬆️
internal/rules/composite_subject_creator.go 100.00% <100.00%> (ø)
internal/x/tracing/provider/instana/logger.go 75.00% <0.00%> (-25.00%) ⬇️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@dadrus dadrus merged commit 1336777 into main Aug 1, 2022
@dadrus dadrus deleted the feat/authenticators_fallback branch August 1, 2022 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant