"fixed" #577 (improving the Validate error message)

dadhi · May 26, 2023 · 8859960 · 8859960
1 parent cb6d8c7
commit 8859960
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/DryIoc/Container.cs b/src/DryIoc/Container.cs
@@ -14528,7 +14528,8 @@ public static readonly int
             NoServiceTypesToValidate = Of(
                 "The `serviceTypes` passed to Validate method is null or empty. Please pass the type(s) you want to Validate."),
             ValidateFoundErrors = Of(
-                "Validate found the errors, please check the ContainerException.CollectedExceptions for details."),
+                "Validate method found the errors, please check the ContainerException.CollectedExceptions for the details." + NewLine +
+                "If you see too many (unexpected) errors, try narrowing the resolution roots by passing the selected service types or the condition to the Validate(AndThrow) method."),
             UnableToInterpretTheNestedLambda = Of(
                 "Unable to interpret the nested lambda with Body:" + NewLine + "{0}"),
             WaitForScopedServiceIsCreatedTimeoutExpired = Of(

diff --git a/...6_Extension_methods_not_being_handled_correctly_in_MadeOf_service_returning_expression.cs b/...6_Extension_methods_not_being_handled_correctly_in_MadeOf_service_returning_expression.cs
@@ -12,6 +12,7 @@ public int Run()
             Test_factory_extension_method_for_the_factory_with_the_service_key();
 
             Test_factory_extension_method_GHIssue577();
+
             return 3;
         }
 
@@ -79,8 +80,11 @@ public void Test_factory_extension_method_GHIssue577()
 
             container.Register<Foo>();
 
-            var errors = container.Validate();
-            // Assert.IsEmpty(errors); // todo: @fixme fails here with the root ILogger
+            var errorsAllAreRoots = container.Validate();
+            Assert.AreEqual(1, errorsAllAreRoots.Length); // fails for the non-root logger
+
+            var errorsForLogger = container.Validate(typeof(ILogger));
+            Assert.IsEmpty(errorsForLogger); // fine to validate a specific service
 
             var log = container.Resolve<ILogger>();
             Assert.IsNull(((SerilogLogger)log).TypeName);