Skip to content

Commit

Permalink
[Hub Generated] Review request for Microsoft.Batch to add version sta…
Browse files Browse the repository at this point in the history
…ble/2020-09-01.12.0 (Azure#14170)

* [Batch] Update RemoveNodes description to include max nodes/request

* Added suppressions to readme
  • Loading branch information
dpwatrous authored and dabenhamMic committed May 4, 2021
1 parent 3ce3c51 commit cd0b2c0
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7679,7 +7679,7 @@
}
},
"summary": "Removes Compute Nodes from the specified Pool.",
"description": "This operation can only run when the allocation state of the Pool is steady. When this operation runs, the allocation state changes from steady to resizing.",
"description": "This operation can only run when the allocation state of the Pool is steady. When this operation runs, the allocation state changes from steady to resizing. Each request may remove up to 100 nodes.",
"x-ms-request-id": "request-id",
"parameters": [
{
Expand Down Expand Up @@ -15862,7 +15862,8 @@
"items": {
"type": "string"
},
"title": "A list containing the IDs of the Compute Nodes to be removed from the specified Pool."
"title": "A list containing the IDs of the Compute Nodes to be removed from the specified Pool.",
"description": "A maximum of 100 nodes may be removed per request."
},
"resizeTimeout": {
"type": "string",
Expand Down
35 changes: 25 additions & 10 deletions specification/batch/data-plane/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,24 +4,24 @@
This is the AutoRest configuration file for Batch.



---

## Getting Started

To build the SDK for Batch, simply [Install AutoRest](https://aka.ms/autorest/install) and in this folder, run:

> `autorest`
To see additional help and options, run:

> `autorest --help`
---

## Configuration



### Basic Information

These are the global settings for the Batch API.

``` yaml
Expand Down Expand Up @@ -113,6 +113,7 @@ input-file:
## Suppression

Note that this setting should be removed once [this GitHub bug](https://github.com/Azure/azure-openapi-validator/issues/68) is fixed.

``` yaml
directive:
- suppress: R2063
Expand All @@ -121,6 +122,7 @@ directive:
```

Note that this setting should be removed once [this GitHub bug](https://github.com/Azure/azure-openapi-validator/issues/69) is fixed.

``` yaml
directive:
- suppress: R2064
Expand Down Expand Up @@ -216,6 +218,20 @@ directive:
reason: The suggested casing of this property is worse than the casing that we're using
```

``` yaml
- suppress: DefinitionsPropertiesNamesCamelCase
where: $.definitions.ImageInformation.properties.nodeAgentSKUId
from: BatchService.json
reason: Changing the casing of this property would be a breaking change
```

``` yaml
- suppress: AvoidNestedProperties
where: $.definitions.NodeFile.properties.properties
from: BatchService.json
reason: Switching to x-ms-client-flatten would be a breaking change to the SDKs
```

### Tag: package-2017-05.5.0

These settings apply only when `--tag=package-2017-05.5.0` is specified on the command line.
Expand All @@ -225,7 +241,6 @@ input-file:
- Microsoft.Batch/stable/2017-05-01.5.0/BatchService.json
```


### Tag: package-2017-01.4.0

These settings apply only when `--tag=package-2017-01.4.0` is specified on the command line.
Expand Down Expand Up @@ -262,10 +277,9 @@ input-file:
- Microsoft.Batch/stable/2015-12-01.2.2/BatchService.json
```


---
# Code Generation

# Code Generation

## Swagger to SDK

Expand Down Expand Up @@ -311,11 +325,13 @@ python:
package-name: azure-batch
clear-output-folder: true
```

``` yaml $(python) && $(python-mode) == 'update'
python:
no-namespace-folders: true
output-folder: $(python-sdks-folder)/azure-batch/azure/batch
```

``` yaml $(python) && $(python-mode) == 'create'
python:
basic-setup-py: true
Expand Down Expand Up @@ -357,7 +373,7 @@ java:
output-folder: $(azure-libraries-for-java-folder)/azure-batch
```

## Multi-API/Profile support for AutoRest v3 generators
## Multi-API/Profile support for AutoRest v3 generators

AutoRest V3 generators require the use of `--tag=all-api-versions` to select api files.

Expand Down Expand Up @@ -386,11 +402,10 @@ input-file:
```

If there are files that should not be in the `all-api-versions` set,
If there are files that should not be in the `all-api-versions` set,
uncomment the `exclude-file` section below and add the file paths.

``` yaml $(tag) == 'all-api-versions'
#exclude-file:
# - $(this-folder)/Microsoft.Example/stable/2010-01-01/somefile.json
```

0 comments on commit cd0b2c0

Please sign in to comment.