Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readtime #594

Closed
wants to merge 8 commits into from
Closed

Add readtime #594

wants to merge 8 commits into from

Conversation

rubyontherez
Copy link

Feature suggestion - "How to display the time of reading on the blog #593"

This file makes it possible to use {% include readtime.html %} wherever an estimated read time is desired (such as next to post date).

Feature suggestion - "How to display the time of reading on the blog #593"
@daattali
Copy link
Owner

Thank you @rubyreads

In order to add this feature, we would want to really integrate it , rather than leave it in the source code as something undocumented that will get hidden. Could you add this in an appropriate location in the post header, along with some appropriate CSS, and add a config param to turn this on/off (default to off)? The goal is that anyone forking this theme will be able to intuitively and easily find this and enable it

@rubyontherez
Copy link
Author

@daattali -- this is my first pull request on a public repo... I'll do my best. Thank you 🙂

@memoriesus
Copy link

But maybe it is not available

@rubyontherez
Copy link
Author

I created a new pull request #595 (which has all the necessary commits).

O-Mutt pushed a commit to O-Mutt/o-mutt.github.io that referenced this pull request Apr 24, 2020
Add readtime config param
O-Mutt pushed a commit to O-Mutt/o-mutt.github.io that referenced this pull request Apr 24, 2020
Add code that calculates estimated read time
O-Mutt pushed a commit to O-Mutt/o-mutt.github.io that referenced this pull request Apr 24, 2020
Add readtime to post-meta if config param enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants