Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing og:image to absolute URL #258

Closed
wants to merge 1 commit into from
Closed

Conversation

sumitgpt
Copy link

@sumitgpt sumitgpt commented Oct 3, 2017

Relative URL can cause problems with some website. Absolute URLs are recommended.

Relative URL can cause problems with some website. Absolute URLs are recommended.
@daattali
Copy link
Owner

daattali commented Oct 3, 2017

You're absolutely right. In fact I have an issue #254 open for this, because this needs to be fixed in multiple places. But it may not be as simple as simply adding {{ site.url }} as you have done; this will work for local images that are hosted in the repo, but it will break images that are external and use an http/https URL. Does that make sense?

@daattali
Copy link
Owner

daattali commented Oct 3, 2017

@OCram85 this is that big issue that I told you about that I think is important :)

@OCram85
Copy link
Contributor

OCram85 commented Oct 4, 2017

@daattali I try working on a solution as soon as possible.

@daattali
Copy link
Owner

daattali commented Oct 4, 2017

No rush!

@daattali
Copy link
Owner

@sumitgpt closing this PR since it does not solve the larger issue. Feel free to submit a PR for #254 :)

@daattali daattali closed this Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants