refactor: [torrust#852] eenrich field types in HealthCheckApi config …

…struct

packages/configuration/src/v1/health_check_api.rs

@@ -1,3 +1,5 @@
+use std::net::{IpAddr, Ipv4Addr, SocketAddr};
+
 use serde::{Deserialize, Serialize};
 use serde_with::serde_as;
 
@@ -9,13 +11,13 @@ pub struct HealthCheckApi {
     /// The format is `ip:port`, for example `127.0.0.1:1313`. If you want to
     /// listen to all interfaces, use `0.0.0.0`. If you want the operating
     /// system to choose a random port, use port `0`.
-    pub bind_address: String,
+    pub bind_address: SocketAddr,
 }
 
 impl Default for HealthCheckApi {
     fn default() -> Self {
         Self {
-            bind_address: String::from("127.0.0.1:1313"),
+            bind_address: SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 1313),
         }
     }
 }

packages/test-helpers/src/configuration.rs

@@ -1,6 +1,6 @@
 //! Tracker configuration factories for testing.
 use std::env;
-use std::net::IpAddr;
+use std::net::{IpAddr, Ipv4Addr, SocketAddr};
 
 use torrust_tracker_configuration::Configuration;
 use torrust_tracker_primitives::TrackerMode;
@@ -39,7 +39,7 @@ pub fn ephemeral() -> Configuration {
 
     // Ephemeral socket address for Health Check API
     let health_check_api_port = 0u16;
-    config.health_check_api.bind_address = format!("127.0.0.1:{}", &health_check_api_port);
+    config.health_check_api.bind_address = SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), health_check_api_port);
 
     // Ephemeral socket address for UDP tracker
     let udp_port = 0u16;

src/bootstrap/jobs/health_check_api.rs

@@ -42,7 +42,7 @@ use crate::servers::service::Service;
 #[allow(clippy::async_yields_async)]
 #[instrument(ret, fields(registar = %registar))]
 pub async fn start_job(config: &HealthCheckApi, registar: &Registar, version: Version) -> JoinHandle<()> {
-    let addr = config.bind_address.parse().expect("it should parse the binding address");
+    let addr = config.bind_address;
 
     let form = registar.form();
     let registry = registar.as_ref().clone();

tests/servers/health_check_api/environment.rs

@@ -23,10 +23,7 @@ impl Environment {
     pub async fn new(config: &Arc<HealthCheckApi>, registar: &Registar) -> Self {
         let registry = registar.as_ref().clone();
 
-        let addr = config
-            .bind_address
-            .parse::<std::net::SocketAddr>()
-            .expect("it should have a valid http tracker bind address");
+        let addr = config.bind_address;
 
         let form = registar.form();