-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QUERY_ALL_PACKAGES not granted on Samsung (Android 14) #1015
Comments
VID_20240218_092433_01.mp4 |
Please provide a debug log of this: |
OK, I will try to post the debug log later. |
Here is the debug log. I noticed that on android 14, there's no selection of grant access to android/data folder under manager storage, but on android 10, there is selection for grant access to android/data folder. I guess this is the reason why SD maid SE's app cleaner does not work on android 14, how can I grant access to android/data? |
Not only appcleaner, click appcontrol will also cause SD Maid SE to quit at once. I think the problem is because SD maide SE has not granted access to android/data. |
The issue is with your systems package manager. This is a "safety crash": 2024-02-19T05:12:14.805Z E/SDMSE:App: UNCAUGHT EXCEPTION: eu.darken.sdmse.common.pkgs.pkgops.IllegalPkgDataException: No installed packages
at eu.darken.sdmse.common.pkgs.sources.PackageManagerPkgSource.access$getCoreList(Unknown Source:232)
at eu.darken.sdmse.common.pkgs.sources.PackageManagerPkgSource$getCoreList$1.invokeSuspend(Unknown Source:11)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:8)
at kotlinx.coroutines.DispatchedTask.run(Unknown Source:107)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(Unknown Source:93)
Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: There should never be 0 pkgs, as there are always some system apps installed:
Any idea why this would be? 🤔 |
Oh, I'm so stupid that just noticed that I haven't given SD maid SE permission to app list, need to go to setting - app - SD Maid SE and allow permission to app list, the app itself do not pop up ask for permission to app list. |
Is this a special Samsung only setting? Can you show me a screenshot? 🤔 |
Below 2 pictures are from oneplus 7T, Android 10 phone, there's no permmission for app list: Below 2 pictures are from samsung galaxy 24+ phone, Android 14, there's permmission option named app list: |
This should have been granted by default, did you manually disable it? |
I never disable it manually, the app did not ask me for allowing on installation, at first I just stuck with "android restricted access to android/data folder from android 11 on" issue, later when I came to app setting then realized the crash was casued by applist permission. |
This is normally not a permission that can't be taken away. The S24+ is a popular device, if this is not granted by default, then I would expect to get more feedback about crashes 🤷.
Thanks for the report!
The permission is new, I think Android 12 or 13+, it's just unusual that it's visible and can be taken away. The permission has to be declared by developer and is automatically granted, but Google Play requires devs to provide an explanation on why the permission is requested. |
Actually, let's leave this open for now, I'll look into whether SD Maid can handle this without crash and show a setup card with instructions for Samsung devices... |
…e devices Previous we always assumed that QUERY_ALL_PACKAGES was granted (which it should, by default), but Samsung seems to be doing "Just Samsung things ™️" and this may not be the case on some of Samsungs Android 14 ROMs. So let's treat it as potentially optional and catch the error, don't crash, and guide the user to the setup. Closes #1015
Still don't get what Samsung is doing here except, but #1033 will make SD Maid not crash and handle this more gracefully, i.e. show a hint to the user about it. Thanks for bringing this to my attention @dancorpse |
…e devices Previous we always assumed that QUERY_ALL_PACKAGES was granted (which it should, by default), but Samsung seems to be doing "Just Samsung things ™️" and this may not be the case on some of Samsungs Android 14 ROMs. So let's treat it as potentially optional and catch the error, don't crash, and guide the user to the setup. Closes #1015
Describe the bug
Just install SD maid SE on my new Android 14 phone but once I click appcleaner the app stop and quit by itself right away. But it can work on my android 10 old phone. I noticed that there’s no grant access to android/data folder on Android 14.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Is that because of android’s restriction to android/data folder from Android 11 on?
Any way to solve?
Smartphone (please complete the following information):
Screenshots/Video
Not able to screen shot bcs the app quit at once
The text was updated successfully, but these errors were encountered: