Support esm on node with conditional exports #3366
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 13.6 node is able to load esm without the
--experimental-modules
flag, and since 13.7 node supports conditional exports unflagged as well.While node can import cjs code from esm code just fine, currently only
is possible. If you try
you get
because Node doesn't support named exports from cjs modules.
I modified the build config to build an esm file for node as well and made sure node can find it using the conditional exports.
I am aware that the node version of d3 simply exports the individual
d3-*
modules whereas my build fully includes them in the code. I think that eventually the conditional exports should be used in each of thed3-*
modules. I just wanted to add this as a PoC however to open up the discussion without going through all the work of implementing the conditional exports in each of the submodules.