Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for stratify.path #187

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fixes for stratify.path #187

merged 1 commit into from
Dec 9, 2021

Conversation

mbostock
Copy link
Member

@mbostock mbostock commented Dec 9, 2021

We missed a few edge cases in the stratify.path implementation. I’ve added more tests and a notebook here:

https://observablehq.com/d/0517f931bb264fe5

The main bug is that we weren’t handling single-character folder names (as in “/d/0517f931bb264fe5”) correctly. I also changed the behavior with respect to trailing slashes such that a trailing slash will not be stripped if it is preceded by another slash.

@mbostock mbostock requested a review from Fil December 9, 2021 00:18
@mbostock mbostock merged commit 296e8c4 into main Dec 9, 2021
@mbostock mbostock deleted the mbostock/stratify-path-fix branch December 9, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants