Accept iterables. #155
Merged
Accept iterables. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fil
approved these changes
Nov 17, 2019
| var tape = require("tape"), | ||
| d3 = require("../../"); | ||
|
|
||
| tape("d3.hierarchy(data, children) supports iterable children", function(test) { |
There was a problem hiding this comment.
a detail, but the "children" argument listed in this comment is not used
|
Sure, I’d love test contributions. |
|
I made some tweaks so that you can pass a rollup or group Map directly to d3.hierarchy and it’ll work out of the box, and I’ve been tinkering with the d3-hierarchy notebooks to make it easier to override the data (e.g., using d3.stratify or d3.rollup without needing to change the rest of the code). Let me know if you have any thoughts there. |
|
One joyful discovery is that, now that hierarchies are iterable, they work beautifully with the new d3-array, e.g. const [x0, x1] = d3.extent(root, d => d.x); |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Mike Bostock <mbostock@gmail.com>
rescale epsilon to the circles' magnitude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94.
Fixes #140.
Fixes #154.
Fixes #67.