Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax intersection test. #111

Merged
merged 8 commits into from
Apr 16, 2018
Merged

Relax intersection test. #111

merged 8 commits into from
Apr 16, 2018

Commits on Apr 15, 2018

  1. Configuration menu
    Copy the full SHA
    c72a442 View commit details
    Browse the repository at this point in the history
  2. Test for inconsistencies between place() and intersects()

    We’re looking for cases where place(a, b, c) will place c so it
    intersects with a or b.
    robinhouston committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    c990e73 View commit details
    Browse the repository at this point in the history
  3. More readable output

    robinhouston committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    0aa0b1a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ea77784 View commit details
    Browse the repository at this point in the history
  5. New place() function that avoids overlaps

    The old place(a, b, c) function would sometimes place c so it overlapped
    with a and/or b, if c had a much larger radius than a and b.
    
    This version doesn’t seem to.
    
    As per discussion on #111.
    
    This commit also updates the tests in find-place-bugs.js to
    use the new function, and updates the intersection test in
    siblings-test.js to match
    
    Note that flare-test.js fails. I haven’t investigated why: I hope it is simply
    a result of the changes in numerical precision causing slightly different
    circle placements.
    robinhouston committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    f2ceeca View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2018

  1. Avoid an avoidable sqrt()

    Since the values that had been divided by scale = sqrt(dc) are
    only being used in pairs, we can avoid the square root and just
    divide by dc instead.
    
    This should help with the precision, marginally, I hope.
    robinhouston committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    125af32 View commit details
    Browse the repository at this point in the history
  2. Tweak form.

    mbostock committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    fc85b75 View commit details
    Browse the repository at this point in the history
  3. Update test script.

    mbostock committed Apr 16, 2018
    Configuration menu
    Copy the full SHA
    7827beb View commit details
    Browse the repository at this point in the history