-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax intersection test. #111
Merged
Merged
Commits on Apr 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c72a442 - Browse repository at this point
Copy the full SHA c72a442View commit details -
Test for inconsistencies between place() and intersects()
We’re looking for cases where place(a, b, c) will place c so it intersects with a or b.
Configuration menu - View commit details
-
Copy full SHA for c990e73 - Browse repository at this point
Copy the full SHA c990e73View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa0b1a - Browse repository at this point
Copy the full SHA 0aa0b1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea77784 - Browse repository at this point
Copy the full SHA ea77784View commit details -
New place() function that avoids overlaps
The old place(a, b, c) function would sometimes place c so it overlapped with a and/or b, if c had a much larger radius than a and b. This version doesn’t seem to. As per discussion on #111. This commit also updates the tests in find-place-bugs.js to use the new function, and updates the intersection test in siblings-test.js to match Note that flare-test.js fails. I haven’t investigated why: I hope it is simply a result of the changes in numerical precision causing slightly different circle placements.
Configuration menu - View commit details
-
Copy full SHA for f2ceeca - Browse repository at this point
Copy the full SHA f2ceecaView commit details
Commits on Apr 16, 2018
-
Since the values that had been divided by scale = sqrt(dc) are only being used in pairs, we can avoid the square root and just divide by dc instead. This should help with the precision, marginally, I hope.
Configuration menu - View commit details
-
Copy full SHA for 125af32 - Browse repository at this point
Copy the full SHA 125af32View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc85b75 - Browse repository at this point
Copy the full SHA fc85b75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7827beb - Browse repository at this point
Copy the full SHA 7827bebView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.