This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
[DCOS-44001] Remove pycrypto-2.6.1 which has a security vulnerability. #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This approach doesn't fix the dcos-commons-base image location in the Docker file. Closing PR. |
…& Dockerfile.base -> Dockerfile. This is due to https://github.com/mesosphere/data-services-release-tooling/blob/b5015284d5668bda7cbba58fd133a1e46680d074/docker_tools.py#L16 making assumptions about the file. We will create a new dcos-commons-base image via this approach.
|
Built new dcos-commons-base image via: Note, branch dcos-44001-fix-dcos-base-image should NOT be merged. It renames For the Jenkins job above to work. |
kaiwalyajoshi
added a commit
that referenced
this pull request
Nov 16, 2018
GitHub PR: #2784 was used as an intermediate step to generate the dcos-commons-base image.
kaiwalyajoshi
added a commit
that referenced
this pull request
Nov 20, 2018
* Update cryptography and requests PyPi versions. * Replace PyCrpto with PyCryptoDome. PyCrytoDome is intended to be a drop-in replacement for PyCrypto, and PyCrypto is dead according to this URL:pycrypto/pycrypto#253 (comment) * Remove pycrypto-2.6.1 which has a security vulnerability. * Update Dockerfile to use updated docker-commons-base image. GitHub PR: #2784 was used as an intermediate step to generate the dcos-commons-base image. * Pull dcos-commons-base as tagged image as opposed to sha256. * Use image SHA-256 hash instead of GIT-SHA for Dockerfile.base
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of two fixes. This one fixes the dcos-commons-base image.